rtCamp / blank-theme

Customized Blank theme based on Underscore and Foundation
25 stars 23 forks source link

Php Unit test case setup #33

Open DevikVekariya opened 4 years ago

DevikVekariya commented 4 years ago

Acceptance Criteria:

umeshnevase commented 4 years ago

@DevikVekariya

I'm assuming it will take 3-4 days. I'll try to finish as soon as possible. I've considered some extra buffer, because working for the first time.

DevikVekariya commented 4 years ago

@kiranpotphode I wanted to split this issue between multiple folks.


Assign PRs to @deepaklalwani97 for the Review

deepaklalwani97 commented 4 years ago

@kiranpotphode Can you merge this branch #45 to your branch with PHPUnit configuration and close this PR. As master branch does not contain a unit test setup and we cannot merge it without checks passing.

DevikVekariya commented 4 years ago

@deepaklalwani97

Raise the PR from your test-case branch to dev-unit-test

Merge your PR to dev-unit-test, then all will pull dev-unit-test to their working branch.

deepaklalwani97 commented 4 years ago

Merged to dev-unit-test

deepaklalwani97 commented 4 years ago

@juhi123 The dev-unit-test branch needs to be QA tested before we can merge it to develop. Please test the dev-unit-test branch and add your findings.