search

rtCamp / blank-theme

Customized Blank theme based on Underscore and Foundation
25 stars 23 forks source link

Update NPM Packages and Webpack config #67

Closed manishsongirkar closed 3 years ago

manishsongirkar commented 3 years ago

@mrrobot47 This is our base theme for any theme development and PHPCS is getting failed because of the following error.

[ERROR] Secret `GH_BOT_TOKEN` or `VAULT_TOKEN` is missing. Please add it to this action for proper execution.

Is this fine and ignore this as it's a blank theme or can we get it fixed?

@chandrapatel We can merge the above changes in master. And fix the above error in the new branch.

mrrobot47 commented 3 years ago

@manishsongirkar @chandrapatel is this repo used as a base to create other repos like https://github.com/rtCamp/wordpress-skeleton or https://github.com/rtCamp/vip-go-skeleton?

If so, then need to update actions a little (as in our private repos we use self-hosted runners). Otherwise will add the secrets needed to run this action and fix the issue directly.

chandrapatel commented 3 years ago

@mrrobot47 Yes, we are using this repo as base for new theme. So please update GH actions.

mrrobot47 commented 3 years ago

@manishsongirkar once https://github.com/rtCamp/blank-theme/pull/68 is merged, you can merge those changes in this PR, then workflow will run without any issues and will check for PHPCS issues on this PR.

manishsongirkar commented 3 years ago

@mrrobot47 Workflow works fine now.