Closed divyarajmasani closed 3 years ago
@manishsongirkar some nice suggestions you have pointed there, I'd similar thoughts on clean up as well. I'll try to accommodate all your suggestions.
Apart from this, I wanted to replace use of flex-grid
with [XY-Grid](https://get.foundation/sites/docs/xy-grid.html)
, underneath it uses flex only, but to be par with the foundation we should try to avoid using flex-grid
classes as it's been tagged as legacy
.
let me know your thoughts.
$print-breakpoint
variable, to make sure breakpoints work as expected, foundation defaults tolarge
flex-grid
linters
to run onprecommit
for diff.Next
[ ] Setup test suit for php ( has a PR )
[ ] Setup test suit for JS
[ ] Setup visual tests