rtCamp / blank-theme

Customized Blank theme based on Underscore and Foundation
25 stars 23 forks source link

Udpate theme init script #76

Closed thelovekesh closed 2 years ago

thelovekesh commented 2 years ago

Description

Technical Details

Checklist

Screenshots

image

image

To-do

Fixes/Covers issue

Fixes #75

thelovekesh commented 2 years ago

What if the script was re-usable? What if we could rename/search-replace the theme multiple times? I believe this would require search-replacing in the init.js file as well. Is something like this possible?

Yes it can be done, we only need to remove bin directory from dirOrFilesIgnore array.

We need to add a maybe cleanup command which should remove the .git folder and init.js file and other unnecessary files which are no more required once the setup is done. This command could be triggered manually as well or we could prompt the user once the search-replace is done on whether they wish to remove those files.

Also, I am in favor of providing a custom cleanup command instead of handling cleaning from npm:init command itself.

@RahiDroid Should I add commits for these two features?

RahiDroid commented 2 years ago

What if the script was re-usable? What if we could rename/search-replace the theme multiple times? I believe this would require search-replacing in the init.js file as well. Is something like this possible?

Yes it can be done, we only need to remove bin directory from dirOrFilesIgnore array.

We need to add a maybe cleanup command which should remove the .git folder and init.js file and other unnecessary files which are no more required once the setup is done. This command could be triggered manually as well or we could prompt the user once the search-replace is done on whether they wish to remove those files.

Also, I am in favor of providing a custom cleanup command instead of handling cleaning from npm:init command itself.

@RahiDroid Should I add commits for these two features?

@thelovekesh Go ahead please!