search

rtCamp / frappe-slack-connector

Frappe app that integrates the Leave Management module with Slack
GNU Affero General Public License v3.0
3 stars 2 forks source link

fix: show task name as description, raise limit to 99, check if project not found while selecting task #57

Closed ananyo141 closed 1 day ago

ananyo141 commented 2 days ago

Issue

If the project is deleted or not found for selected task, it is giving error:

cannot unpack non-iterable NoneType object

since the code is trying to get the fields for the project that is being returned None.

Solution

  1. This PR adds a check if the ORM call returns None, it shows a user friendly message saying the project doesn't exist.
  2. Adds the Task Name (TASK-0001) to the description
  3. Raise the tasks and project limit to 99 (maximum permissible by Slack is 100)