search

rtCamp / login-with-google

Minimal plugin which allows WordPress user to login with google.
https://wordpress.org/plugins/login-with-google/
GNU General Public License v2.0
63 stars 17 forks source link

Compatibility issue with PHP 8.1 #104

Open Giovannss-ctrl opened 2 years ago

Giovannss-ctrl commented 2 years ago

When I update the PHP version to 8.1, this error appears:

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /web/htdocs/www.mydomain.com/home/wp-content/plugins/login-with-google/src/Utils/Helper.php on line 90

aviral-mittal commented 2 years ago

@abhishekfdd As discussed, even when fixing this issue for PHP8.1 , we will maintain back compatibility as well.

aviral-mittal commented 2 years ago

@abhishekfdd Do we have any updates for this?

aviral-mittal commented 2 years ago

@abhishekfdd As discussed, please drop an update with your findings so far here.

abhishekfdd commented 2 years ago

@aviral-mittal FILTER_SANITIZE_STRING has been deprecated in PHP 8.1 and will result in warning. We need to modify this function to use other appropriate sanitization function.

Since there are many references to this in our plugin it can be time consuming so let's keep this for future versions when we will provide full compatibility with PHP 8.1

kudlav commented 1 year ago

Also discussed here: https://wordpress.org/support/topic/compatibility-with-php-8-1-6/

jesperronn commented 8 months ago

is this issue still relevant to keep open now that #158 is merged?