Make the plugin multisite compatible

rtCamp / login-with-google

Minimal plugin which allows WordPress user to login with google.

https://wordpress.org/plugins/login-with-google/

GNU General Public License v2.0

63 stars 17 forks source link

Make the plugin multisite compatible #119

Closed aviral-mittal closed 1 year ago

aviral-mittal commented 2 years ago

Issue Description

Need to make the plugin multisite compatible. As encountered here, the plugin is probably not multisite compatible as of now.

Please investigate the same and if not, please make the plugin multisite compatible.

abhishekfdd commented 2 years ago

@aviral-mittal Tested this on subdirectory multisite setup with version 1.2.2 currently on Wordpress Repo, Works fine for me

aviral-mittal commented 2 years ago

@Rink9 Can you please test the last released version on multisite setup to check if any problems are being faced?

Rink9 commented 2 years ago

@abhishekfdd I have activated Login with Google plugin on my multisite. And also setup the steps mentioned on here. But still it's not working and getting this error. Sharing my site access on your dm.

Ref: https://lutfun-rinky.rt.gw/

aviral-mittal commented 2 years ago

@abhishekfdd This is important and we should fix this asap.

abhishekfdd commented 2 years ago

@Rink9 I am not able to reproduce the error above but instead I am getting this error.

Seems redirect uri parameter is not configured correctly for this susbsite. ( Needs to done from google developer console )

cc @aviral-mittal

abhishekfdd commented 2 years ago

@Rink9 Maybe you are checking at wrong url, if you have configured the Client ID detail for subsite bbpress then you should check that from here https://lutfun-rinky.rt.gw/bbpress/wp-admin

Rink9 commented 2 years ago

@abhishekfdd I have setup for https://lutfun-rinky.rt.gw/ URL. If a user has one multisite and they setup only for main/parent site it should work with it's all subsite. If we have still to setup particularly for every subsite though it's multisite then how we are making this compatible with multisite?

Actual behaviour: Works only when particularly setup for subsites. Expected behaviour: If we setup on main/parent site it should work with it's all subsites.

Please let me know if i am incorrect.

cc: @aviral-mittal

abhishekfdd commented 2 years ago

@Rink9 This plugin needs google client ID and key, which will be unique for every domain so same key won't work for all the sites. This is how google authentication API works nothing to do with our plugin.

Rink9 commented 1 year ago

@abhishekfdd Let's connect on a call and discuss about it. Somehow i am not able to connect though added Google client ID and key.

Rink9 commented 1 year ago

@abhishekfdd As discussed on call mainly have to add Client ID and Secrets from all the subsites. Also have to add all the subsites from google console. My confusion was if we add on parent site it will work on all the subsites but we have to add Client ID and Secrets individually from all the subsites then it will work. As in this use case Login-with-google is working.

https://user-images.githubusercontent.com/44554636/188834347-a1a9f29e-0e3b-47bf-b0a1-765897ef1fcd.mov

cc: @aviral-mittal