Closed marceldarvas closed 1 year ago
I have got the redirection to work. However, I am still experiencing issues caused by the shortcode.
I've found RtCamp\GoogleLogin\Modules\Shortcode::scan_shortcode() to be an issue when running the CSS Cache regeneration process via the Oxygen Builder Admin Panel.
Argument #1 ($output) must be of type string, null given
Upon disabling this plugin, the regeneration process runs fine. (I had errors in Oxygen Templates giving failed AJAX requests).
I found the issue to be related to Oxygen Builders: Reusable Part Components. Although I believe some error-handling improvements could be made to the shortcode functionality of this plugin.
I've tested various formats (with or without a hostname) for redirect_to URL, but it always seems to redirect back to the URL that it was displayed on.
I found this bug to have been addressed before: https://github.com/rtCamp/login-with-google/pull/96
I've checked my LiteSpeed Cache config + Cloudflare, but it remains an issue.
Additionally, I investigated this issue because from the Login Screen (with wp-login.php?redirect_to="") the query params are preserved and working fine.
There also seems to be a typo in the shortcode example here as there's a '/' at the end that doesn't belong there.
I'm not the only one seeming to have issues with this: https://github.com/rtCamp/login-with-google/issues/154
I've also tried using the rtcamp.google_default_redirect filter to override, but it didn't seem to work in my case.
I was wondering why do you have this code: https://github.com/rtCamp/login-with-google/blame/0c4ee9c222ff6455b2e8c89d226e15708087401b/src/Modules/Shortcode.php#L147