Update pimple container version

rtCamp / login-with-google

Minimal plugin which allows WordPress user to login with google.

https://wordpress.org/plugins/login-with-google/

GNU General Public License v2.0

57 stars 17 forks source link

Update pimple container version #162

Closed NikhilJoshua closed 10 months ago

NikhilJoshua commented 10 months ago

Summary

Update Pimple version to 3.5.* in composer.json for PHP 8.1 Compatibility

closes #161

github-actions[bot] commented 10 months ago

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/162/merge/

pavanpatil1 commented 10 months ago

Hi @NikhilJoshua, Verified the PR but while activating the plugin there's fatal error is visible. Please check:

NikhilJoshua commented 10 months ago

@pavanpatil1 Can you please try deleting the vendor folder and do a composer install ?

pavanpatil1 commented 10 months ago

Hi @NikhilJoshua, after executing the above steps able to activate the plugin successfully. However, user should not perform this extra step to activate the plugin. Could you please check and update the require dependencies.

NikhilJoshua commented 10 months ago

@pavanpatil1 I believe the issue was specific to your system, was not able to replicate in local. Can you please check in any other system to confirm it's not an issue from your side.

pavanpatil1 commented 10 months ago

@NikhilJoshua that shouldn't be the case as the GH action is also failing on same issue

Still, I will cross-checking this once again on rt.gw site

github-actions[bot] commented 10 months ago

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/162/merge/

pavanpatil1 commented 10 months ago

Hi @NikhilJoshua, verified the fix and it is working fine now. Able to activate the plugin successfully and it is working fine. However, there are still some deprecated notices after adding the login with google block -

github-actions[bot] commented 10 months ago

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/162/merge/

pavanpatil1 commented 10 months ago

Verified the fix and it is working fine now. The deprecated notices are not visible now. @NikhilJoshua you can merge the PR to master.

Just the check the inspection check why it it failing.

github-actions[bot] commented 10 months ago

Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/162/merge/

NikhilJoshua commented 10 months ago

@pavanpatil1 Fixed the phpcs scan on vendor folder. Please check.

pavanpatil1 commented 10 months ago

Hi @NikhilJoshua, It is working fine now. Please get the PR reviewed and merged.