Fantastic, has bug (from WP.org)

rtCamp / login-with-google

Minimal plugin which allows WordPress user to login with google.

https://wordpress.org/plugins/login-with-google/

GNU General Public License v2.0

57 stars 17 forks source link

Fantastic, has bug (from WP.org) #176

Open joelabreo227 opened 1 month ago

joelabreo227 commented 1 month ago

Original report: https://wordpress.org/support/topic/fantastic-has-bug/#new-post

Existing PR (potentially stale): https://github.com/rtCamp/login-with-google/pull/144

### Tasks
- [ ] On successful login, redirect the user to home_url()
- [ ] User registration flow https://github.com/rtCamp/login-with-google/issues/176#issuecomment-2128846812
- [x] Remember me research: Find out how much WP Core defaults to

joelabreo227 commented 1 month ago

Changelog:

If the plugin setting is ON and the WP setting is OFF, Login with Google with still create a user.
- Basically, there are two different user creation flows, our and WP core's and we're keeping them separate
When a user installs the plugin, the "register new user" will now be ON by default (since that's what the user installed the plugin to do, and presumably is expecting)
- Existing users' install should NOT be affected

SH4LIN commented 1 month ago

Remember me research: Find out how much WP Core defaults to.

WordPress core will set cookies for 14 days + 1 day when the remember me checkbox is checked.

1 day extra is the login grace period.

This expiry time can be modified using this filter auth_cookie_expiration

CC: @joelabreo227