rtCamp / login-with-google

Minimal plugin which allows WordPress user to login with google.
https://wordpress.org/plugins/login-with-google/
GNU General Public License v2.0
63 stars 17 forks source link

Conflict with aws-ses-wp-mail plugin #22

Closed chandrapatel closed 4 years ago

chandrapatel commented 4 years ago
Error Details
=============
An error of type E_ERROR was caused in line 321 of the file /var/www/htdocs/releases/69/wp-content/plugins/aws-ses-wp-mail/lib/aws-sdk/GuzzleHttp/functions.php. Error message: Cannot redeclare GuzzleHttp\json_encode() (previously declared in /var/www/htdocs/releases/69/wp-content/plugins/wp-google-login/vendor/guzzlehttp/guzzle/src/functions.php:323)

We got this error on rtcamp.com site. guzzlehttp library have been used in wp-google-login and aws-ses-wp-mail plugin. So its conflict and and throwing error.

We need to resolve this error in our plugin.

dhaval-parekh commented 4 years ago

Hey @chandrapatel,

Can you please provide when this Fatal error occurs. It would be great if you can provide a step to reproduce the issue.

I have checked the following use case in the local system after activating and configuring both ("wp-google-login" and "aws-ses-wp-mail") plugins. And in both case I'm not able to reproduce this issue.

chandrapatel commented 4 years ago

@dhaval-parekh We got following email when fatal error occurred on live site.

Howdy!

Since WordPress 5.2 there is a built-in feature that detects when a plugin or theme causes a fatal error on your site, and notifies you with this automated email.

In this case, WordPress caught an error with one of your plugins, AWS SES wp_mail drop-in.

First, visit your website (https://rtcamp.com/) and check for any visible issues. Next, visit the page where the error was caught (https://rtcamp.com/wp-admin/user-new.php) and check for any visible issues.

Please contact your host for assistance with investigating this issue further.

If your site appears broken and you can't access your dashboard normally, WordPress now has a special "recovery mode". This lets you safely login to your dashboard and investigate further.

https://rtcamp.com/wp-login.php?action=enter_recovery_mode&rm_token=SWnqWJrsynbk3dnQf7Xr1c&rm_key=k4A6geS8yuHo5yoJKeIDIG

To keep your site safe, this link will expire in 1 day. Don't worry about that, though: a new link will be emailed to you if the error occurs again after it expires.

Error Details
=============
An error of type E_ERROR was caused in line 321 of the file /var/www/htdocs/releases/69/wp-content/plugins/aws-ses-wp-mail/lib/aws-sdk/GuzzleHttp/functions.php. Error message: Cannot redeclare GuzzleHttp\json_encode() (previously declared in /var/www/htdocs/releases/69/wp-content/plugins/wp-google-login/vendor/guzzlehttp/guzzle/src/functions.php:323)

First, visit your website (https://rtcamp.com/) and check for any visible issues. Next, visit the page where the error was caught (https://rtcamp.com/wp-admin/user-new.php) and check for any visible issues.

As per this message, fatal error occurred while creating user.

dhaval-parekh commented 4 years ago

Hey @chandrapatel ,

I have checked the issue and found that that is only replicate on an older version of "aws-ses-wp-mail" plugin (GitHub tag 1.0.0). However, That is fixed in a newer version of the plugin. Though It does have an issue that needs to be fixed. (Need to install vendor files. and include in plugin manifest file)

Issue: https://github.com/humanmade/aws-ses-wp-mail/issues/43

chandrapatel commented 4 years ago

@dhaval-parekh Thanks for the update. Can you please test latest version with the help of Radhe?

dhaval-parekh commented 4 years ago

Hey @chandrapatel

I have tested with newer version, And that is working fine. Since, This is issue with "aws-ses-wp-mail" plugin and not with WP Google Login. I'm closing this issue.

Thanks