search

rtCamp / login-with-google

Minimal plugin which allows WordPress user to login with google.
https://wordpress.org/plugins/login-with-google/
GNU General Public License v2.0
64 stars 19 forks source link

Add settings page #45

Closed juhi123 closed 3 years ago

juhi123 commented 4 years ago

Feature description

Add the settings page to add client id, secret key, whitelisted-domains, whichever we add in wp-config.php

Acceptance criteria

  1. Settings link should be given at plugins page Screenshot 2020-05-20 at 1 06 04 PM

  2. Functionality shouldn't be affected

  3. Give link to create project and credentials https://console.developers.google.com/apis/dashboard

juhi123 commented 4 years ago

@itowhid06 Thanks for the PR :) Can you please make a few minor changes to match with WP Core UI

  1. Wrap the settings heading in <div class="wrap"> Screenshot 2020-06-05 at 12 30 11 PM

  2. Change Here to here in this "If you do not have Project and Credentials, you can create one from Here". Also, I think it should be in p tag only

  3. Use <label for="client-id">Client ID</label> for labels, refer general settings wp-admin/options-general.php. You will notice clicking on the label, it focuses the input field

  4. For optional field instead of mentioning in it label, add description right below the input field like in general settings

juhi123 commented 4 years ago

@itowhid06 Also add setting for user registration so this define( 'WP_GOOGLE_LOGIN_USER_REGISTRATION', true ); also can be managed without adding in wp-config.php

itowhid06 commented 4 years ago

@juhi123 All changes have been implemented.