search

rtCamp / nginx-helper

Nginx Helper for WordPress caching, permalinks & efficient file handling in multisite
https://wordpress.org/plugins/nginx-helper/
224 stars 117 forks source link

PHP 8.1 compatibility #291

Closed dhsathiya closed 1 year ago

dhsathiya commented 1 year ago

Getting PHP Deprecated notics when switching my php version from 7.4 to 8.1 Please fix to make your plugin perfectly compatible with php 8.1:

[19-Aug-2022 19:02:23 UTC] PHP Deprecated:  Constant FILTER_SANITIZE_STRING is deprecated in /wp-content/plugins/nginx-helper/admin/class-nginx-helper-admin.php on line 676
[19-Aug-2022 19:02:23 UTC] PHP Deprecated:  Constant FILTER_SANITIZE_STRING is deprecated in /wp-content/plugins/nginx-helper/admin/class-nginx-helper-admin.php on line 681

Ref - https://wordpress.org/support/topic/php-8-1-compatibility-7/

danish17 commented 1 year ago

@Souptik2001, did you make any fixes?

Souptik2001 commented 1 year ago

@danish17 Yes the fixes are done. We are in the testing phase now.

aviral-mittal commented 1 year ago

@Souptik2001 Can you please point us to the PR in which this fix has been made.

Souptik2001 commented 1 year ago

@aviral-mittal I have not yet raised the PR as all the tests are not yet complete. Just FYI here is the branch with the changes - https://github.com/Souptik2001/nginx-helper/tree/fix/GH-291

gagan0123 commented 1 year ago

@Souptik2001 Any estimates on when the tests will be completed?

Souptik2001 commented 1 year ago

@gagan0123 It should be done by tomorrow. Starting with multi-site testing now.

pgnd commented 1 year ago

@Souptik2001 @gagan0123

what are current plans for merging this fix, and pushing a release ?

dhsathiya commented 1 year ago

We have provided PHP8.1 compatibility with the latest release. Closing the issue in favour of the same.