search

rtCamp / nginx-helper

Nginx Helper for WordPress caching, permalinks & efficient file handling in multisite
https://wordpress.org/plugins/nginx-helper/
224 stars 117 forks source link

Labs: GitHub-177: Randomly generate log file's name to enhance log file's security #311

Closed vishalkakadiya closed 5 months ago

vishalkakadiya commented 9 months ago

Nginx-Helper generates a predictable log file on a predefined path, so we are generating the file name randomly so it will be not detected by anyone else then the site Admin.

Ref: https://github.com/rtCamp/labs/issues/177

gagan0123 commented 5 months ago

@vishalkakadiya

Can you check why Playwright tests are failing

vishalkakadiya commented 5 months ago

@pavanpatil1 Can you help here to fix these errors or guide me the next steps as we discussed in the Slack. Thanks!

CC @gagan0123

vishalkakadiya commented 5 months ago

@gagan0123 The tests are fixed and passed now in the CI as well as in the local. Can you review the PR now, thanks! 🙂

CI: https://github.com/rtCamp/nginx-helper/actions/runs/7484035307/job/20370229295?pr=311#step:6:4239

Local:

Screenshot 2024-01-11 at 9 46 24 AM

vishalkakadiya commented 5 months ago

Closing this PR as opened the new PR as discussed with the team.

https://github.com/rtCamp/nginx-helper/pull/316