Move html code to templates

rtCamp / rtMedia

rtMedia (formerly Buddypress Media) adds advanced multimedia functionality to WordPress, BuddyPress and bbPress

https://rtmedia.io/

122 stars 110 forks source link

Move html code to templates #1860

Closed vishalkakadiya closed 2 years ago

vishalkakadiya commented 2 years ago

Ref: https://github.com/rtCamp/rtMedia/issues/1859#issue-1170810447

vishalkakadiya commented 2 years ago

@chandrapatel I have addressed your feedbacks now, thanks!

thebengalboy commented 2 years ago

Test Cases:

Please test the branch on a new site
Test rtMedia Core (feature/refactor-code) independently
Test with all the individual addon installed
Test with Premium version that we built recently

Pradeep1308 commented 2 years ago

@pavanpatil1 Please check the PR

pavanpatil1 commented 2 years ago

Hi @Pradeep1308, Tested the PR. It is working fine with premium also and all the reported issues observed on this PR https://github.com/rtCamp/rtMedia/issues/1866 are fixed and working fine. You can merge the PR if the code review is done.

thebengalboy commented 2 years ago

@pavanpatil1 @Pradeep1308 Code review is already done by @chandrapatel; Do we need to have the code reviewed again? Otherwise, if everything looks good on testing, we can proceed with merging the PR.

Pradeep1308 commented 2 years ago

@thebengalboy Everything looks good in testing, we can proceed with merging. confirm once, then I'll merge.

thebengalboy commented 2 years ago

@Pradeep1308 If both the review and testing are completed, we can merge the PR √ However, after the merge, @pavanpatil1 Please have an overall test on the pre-release branch.