rtCamp / rtMedia

rtMedia (formerly Buddypress Media) adds advanced multimedia functionality to WordPress, BuddyPress and bbPress

https://rtmedia.io/

122 stars 110 forks source link

Add/deactive survey popup #1939

Closed robicse11127 closed 1 year ago

robicse11127 commented 2 years ago

Added deactivation popup survey module in the plugin

1934 1934

pavanpatil1 commented 2 years ago

Hi @robicse11127, Verified the PR. Functionality is working fine. deactivation popup is showing after clicking on deactivating and being able to select and submit it successfully. However, observed a few things. Please check this.

[ ] Fix typos in deactivation popup messages.

Expected typos on these points. :

I couldn't understand how to make it work.
The plugin is great but I need specific features, that you don't support.
The plugin isn't working.
Others.

[ ] Blank white space is visible after opening the deactivation popup.

[ ] After clicking on submit feedback button it is taking some time to deactivate the plugin. So is it possible to show some loader/message till it deactivates?

https://user-images.githubusercontent.com/44057535/182523565-ed4650cb-64f2-4f59-9927-082931813cd5.mp4

robicse11127 commented 2 years ago

@pavanpatil1 I have updated the typo issue and the background blur issue. However the plugin deactivation loading issue - we have no dependency on plugin deactivation process with our API. So we should not add any uploader to it. We have used the default WP plugin deactivation process here.

pavanpatil1 commented 2 years ago

Hi @robicse11127, Verified the fix for the background issue working fine. Still, for the typo issue, one string is remaining. could you please check ?.

pavanpatil1 commented 2 years ago

Verified the PR, the above fixes are working fine. You can merge the PR @robicse11127.

robicse11127 commented 1 year ago

@pavanpatil1 Branch conflicts resolved with pre-release branch

kjnanda commented 1 year ago

@pavanpatil1 Here is my findings.

Expected result - the pop up form should be visible when user click on deactivate plugin link and it should be submitted successfully.

Actual result -

Clicking on deactivate link plugin is deactivate without showing pop up survey form
(Activate it again) Click on deactivate link for the 2nd time - shows the pop up survey form
Unable to submit the survey form
Console shows the error while clicking on Submit and Deactivate button

Please check this visual where it shows the form is not getting opened on first attempt.

deactivate form issue

The console errors log screenshot

pavanpatil1 commented 1 year ago

Hi @kjnanda, The issue seems happening because of HTTP auth on the rtmedia-dev site. I have temporarily removed it for testing. I will add it again once testing done. Can you check once again?

kjnanda commented 1 year ago

@pavanpatil1 It works as expected now.