rtCamp / rtMedia

rtMedia (formerly Buddypress Media) adds advanced multimedia functionality to WordPress, BuddyPress and bbPress
https://rtmedia.io/
123 stars 111 forks source link

Add a validation message before submitting the file for unsupported media type #1970

Closed pavanpatil1 closed 1 year ago

pavanpatil1 commented 1 year ago

Add a validation message before submitting the file for unsupported media type if the uploaded image file won't be supported. User should not be able to post the feed if the media is not supported

Currently, the validation message is visible if the attached media is not supported but still user is able to submit the post and that post title is visible only.

https://user-images.githubusercontent.com/44057535/224694453-bc1ef40d-a294-4ee5-95dd-cc52691dc10a.mp4


elifvish commented 1 year ago

@pavanpatil1 I have raised PR for pre release branch

Please do QA

pavanpatil1 commented 1 year ago

Verified the Fix and It is working fine. The validation message is visible if added the unsupported media and the maximum file limit is also visible.

https://user-images.githubusercontent.com/44057535/228183840-850c8932-11b2-4b84-88db-0bb51f7cdbc0.mp4

kjnanda commented 1 year ago

@pavanpatil1 Unspported file formate issue seems fixed. For MAX files size, it not tested.

kjnanda commented 1 year ago

@Utsav-Ladani Please check my finding below.

https://github.com/rtCamp/rtMedia/assets/15173772/dd38bfeb-da8e-4954-b392-cc5c0da9d83a

https://github.com/rtCamp/rtMedia/assets/15173772/1129b52f-3ece-4770-a9dc-7cf057566954

image

CC @pavanpatil1

Utsav-Ladani commented 1 year ago

Hello @kjnanda,

kjnanda commented 1 year ago

@Utsav-Ladani Without Pro-addon this works as expected. I am able to see pop up when limit crosses.

CC @pavanpatil1

kjnanda commented 1 year ago

This is working as epxected wrt dev branch.

kjnanda commented 1 year ago

Tested after release and it works as expected.