search

rtCamp / rtMedia

rtMedia (formerly Buddypress Media) adds advanced multimedia functionality to WordPress, BuddyPress and bbPress
https://rtmedia.io/
123 stars 111 forks source link

If no audio is found, the notice should be consistent with audio media, also currently, the corresponding notice class is missing in the HTML code. #1981

Closed kjnanda closed 1 year ago

kjnanda commented 1 year ago

As explained in below screenshot, there is the corresponding class .rtmedia-no-media-found shows up when no media found under photos

This notice seems uniform for rest of the media available be it video or any docs type it is same.

Screenshot_2023-07-25_at_10_51_03_AM

However, if you observe the Music tab this class is missing and also the notice is not same as shown in below screenshot.

Screenshot_2023-07-25_at_10_55_30_AM
Utsav-Ladani commented 1 year ago

This bug is produced by the rtMedia Pro plugin. This PR will fix it.

CC: @kjnanda, @pavanpatil1

kjnanda commented 1 year ago

@pavanpatil1 Since the fix is in rtMedia-Pro, how will be able to release it with rtMedia core plugin?

kjnanda commented 1 year ago

@Utsav-Ladani This looks good to me

kjnanda commented 1 year ago

Cross verified wrt dev branch and added fix working properly.

kjnanda commented 1 year ago

Tested after release and it works as expected.