Fix deprecated notices with different PHP version

rtCamp / rtMedia

rtMedia (formerly Buddypress Media) adds advanced multimedia functionality to WordPress, BuddyPress and bbPress

https://rtmedia.io/

123 stars 111 forks source link

Fix deprecated notices with different PHP version #1987

Closed kjnanda closed 1 year ago

kjnanda commented 1 year ago

There are many visible deprecated notices with different PHP versions.

[ ] PHP Version 8.2.8

[ ] PHP Version 8.1.9

[ ] PHP version 8.0.22

image (1)

Test environment used:

1. Variable PHP versions as stated above
2. MySql - 8.0.16
3. Web server - ngnix  
4. WordPress Version - 6.2.2

kjnanda commented 1 year ago

@pavanpatil1 Please do the needful

@Utsav-Ladani I have added test env details too. please check once.

Utsav-Ladani commented 1 year ago

Here is the PR to fix these deprecation errors.

These changes work with all PHP 7.0 and later versions.

CC: @kjnanda, @pavanpatil1

kjnanda commented 1 year ago

@Utsav-Ladani I still see few deprecated errors on different pages from rtMedia plugin.

[ ] With PHP V8.2.8

On media page and On Phots | Music | Video -

https://github.com/rtCamp/rtMedia/assets/15173772/a8468c3d-6a4f-4c07-b4c1-6f654cba6f49

On media edit page -

[ ] With PHP V8.1.9

on media edit page -

[ ] With PHP V8.0.22 - Everything looks fine ✅

Utsav-Ladani commented 1 year ago

Hello @kjnanda, I fix the above errors. Please check and let me know if there are any more.

kjnanda commented 1 year ago

@Utsav-Ladani I have found few more issues on group's page too.

And I believe it must be there on forum pages as well. Kindly check with it.

Utsav-Ladani commented 1 year ago

Hello @kjnanda, I am not getting any deprecation errors with any version of PHP. These errors have been resolved in the current PR. But if it still persists, then please tell me how to reproduce the issue.

kjnanda commented 1 year ago

@Utsav-Ladani I will let you know in sometime.

Utsav-Ladani commented 1 year ago

@kjnanda, I fixed a few other errors. Please let me know if there are more errors.

kjnanda commented 1 year ago

@Utsav-Ladani This is fixed now.

kjnanda commented 1 year ago

I don't see any deprecated errors after fix in dev branch.

kjnanda commented 1 year ago

@pavanpatil1 I am getting the notice on every page of the website. This was not appearing before.

Should I open a new issue and close this?

pavanpatil1 commented 1 year ago

yes, you can close this issue and create new issue for this warning. Also, do check if there are any other warnings do add that as well.

kjnanda commented 1 year ago

reported all the errors have been resolved post release.