Open joelabreo227 opened 1 month ago
Found a deprecated node parser
Fix: Update the node module.
Found several PHPCS issues in multiple files related to 'Short array syntax usage'
Also found the following issues when WordPress-VIP-Go standard was used to check
Fix: Update the syntax and fix all the phpcs issues with WordPress standard and raise a PR to main.
cc: @joelabreo227
theme.json
to provide the end user a lot of preset styles for their new custom themes.@mchirag2002 The flagged issue look fine to be fixed. For below,
Found several PHPCS issues in multiple files related to 'Short array syntax usage'
We at rtCamp prefer to use short-array syntax. So please update the phpcs.xml file to ignore that sniff.
Method 1: Does not work
Steps Followed:
1: setup local site
2: from the themes directory ran the command: composer create-project rtcamp/elementary [folder_name]
3: while going through the themes set up following error occurs:
The log file for the same :
2024-07-19T09_49_42_659Z-debug-0.log
Method 2: Works fine cc: @mchirag2002
Theme check produces errors
Installation Setup:
Method 1: Does not work Steps Followed: 1: setup local site 2: from the themes directory ran the command:
composer create-project rtcamp/elementary [folder_name]
3: while going through the themes set up following error occurs:The log file for the same : 2024-07-19T09_49_42_659Z-debug-0.log
Method 2: Works fine cc: @mchirag2002
I think this is happening because the theme elementary inside our composer package is not updated. What you are facing is an issue that was fixed a long time ago. I'll create task to update the composer theme
Confirm maximum PHP compatibility.
Tested the theme in PHP version 8.3 and everything works perfectly.
Found these css errors while checking for the site on https://validator.w3.org/
cc: @mchirag2002 @SH4LIN
QA Completed Site Tested: Local Site QA Checklist Performed:
Summary
Confirm compatibility with WordPress 6.6.
Team
Primary Assignee: @mchirag2002 PR reviewer: @SH4LIN QA: @maharrshi
References
Acceptance Criteria