Confirm compatibility with WordPress 6.6

joelabreo227 commented 1 month ago

Summary

Confirm compatibility with WordPress 6.6.

Team

Primary Assignee: @mchirag2002 PR reviewer: @SH4LIN QA: @maharrshi

References

https://make.wordpress.org/core/6-6/

Acceptance Criteria

As a WordPress engineer, I can use Elementary to scaffold a brand new project with WordPress 6.6
New features work as expected
Deprecations are gracefully handled

## Additional Tasks
- [ ] Create testing methodology documentation for WP upgrade testing (which can be used going forward) @mchirag2002
- [ ] Support for Interactivity API @SH4LIN
- [ ] Run PHPCS scan @mchirag2002
- [ ] Make sure that README is up to date @mchirag2002
  - [ ] @SH4LIN Add documentation re: how to approach developing a new block
- [ ] Confirm maximum PHP compatibility @SH4LIN
- [ ] Raise PR to address issues encountered https://github.com/rtCamp/theme-elementary/issues/468#issuecomment-2235807396 @mchirag2002
- [ ] Raise PR(s) to address issues encountered https://github.com/rtCamp/theme-elementary/issues/468#issuecomment-2235807396 @mchirag2002

mchirag2002 commented 1 month ago

Things Tested:

Theme installation functionality
Development commands like npm commands.

Issues encountered and fixes for them:

Found a deprecated node parser

Fix: Update the node module.
Found several PHPCS issues in multiple files related to 'Short array syntax usage'

Also found the following issues when WordPress-VIP-Go standard was used to check

Fix: Update the syntax and fix all the phpcs issues with WordPress standard and raise a PR to main.

New features that can be used in the project:

We can now set default font sizes in theme.json

cc: @joelabreo227

mchirag2002 commented 1 month ago

New features that can be used in the project: (Contd.)

We can also leverage the Section Styles feature integrated with the default font size and typography feature in theme.json to provide the end user a lot of preset styles for their new custom themes.

RahiDroid commented 1 month ago

@mchirag2002 The flagged issue look fine to be fixed. For below,

Found several PHPCS issues in multiple files related to 'Short array syntax usage'

We at rtCamp prefer to use short-array syntax. So please update the phpcs.xml file to ignore that sniff.

maharrshi commented 1 month ago

Installation Setup:

Method 1: Does not work Steps Followed: 1: setup local site 2: from the themes directory ran the command: composer create-project rtcamp/elementary [folder_name] 3: while going through the themes set up following error occurs: The log file for the same : 2024-07-19T09_49_42_659Z-debug-0.log

Method 2: Works fine cc: @mchirag2002

maharrshi commented 1 month ago

Theme check produces errors

SH4LIN commented 1 month ago

Installation Setup:

Method 1: Does not work Steps Followed: 1: setup local site 2: from the themes directory ran the command: composer create-project rtcamp/elementary [folder_name] 3: while going through the themes set up following error occurs: The log file for the same : 2024-07-19T09_49_42_659Z-debug-0.log

Method 2: Works fine cc: @mchirag2002

I think this is happening because the theme elementary inside our composer package is not updated. What you are facing is an issue that was fixed a long time ago. I'll create task to update the composer theme

SH4LIN commented 1 month ago

Confirm maximum PHP compatibility.

Tested the theme in PHP version 8.3 and everything works perfectly.

maharrshi commented 1 month ago

Found these css errors while checking for the site on https://validator.w3.org/ cc: @mchirag2002 @SH4LIN

maharrshi commented 1 month ago

QA Completed Site Tested: Local Site QA Checklist Performed:

[x] Installation using two methods as per readme
[x] Theme check - unit testing for the theme
[x] Error logs and console errors checks
[x] CSS Validation
[x] Performance check
[x] Cross Browser Tested(Chrome, Safari, Edge)
[x] Responsive Testing cc: @joelabreo227

rtCamp / theme-elementary