search

rtakehara / 5e-Framework

A comprehensive 5th Edition Dungeons & Dragons Framework for MapTool.
GNU Affero General Public License v3.0
52 stars 9 forks source link

dice rolls matches the ADV or DIS everytime #40

Closed Sigmundx closed 3 years ago

Sigmundx commented 3 years ago

Describe the bug Anytime you would roll anything that can have ADV or DIS from any character sheet or statblock it matches either the ADV or DIS everytime. So instead of three seperate rolls there is only two with the normal roll matching one of the other two.

To Reproduce Steps to reproduce the behavior:

  1. Go to token with character sheet or statblock
  2. Click on any roll that can have DIS or ADV
  3. Look at base roll and ADV/DIS
  4. it will match one of the two everytime

Expected behavior The base roll should roll differently from both of the rolls. (There will of course be circumstances where it will match one or both but it seems unlikely that it will match one or the other everytime)

Screenshots image

Desktop (please complete the following information):

Extra Info Any info on what i can change in what macro to fix this issue or at least be able to edit it to where it only does two dice rolls (since you will only ever have Dis or ADV and not both at the same time) or a way to remove both the ADV and DIS so its just a singular roll. I don't know enough about maptools macro language to figure out what i would need to do to edit this.

Thank you in advance!

Sigmundx commented 3 years ago

I looked at this again and realized how the dice are rolling and how it is being displayed and feel a little dumb. I guess my main problem is i personally don't like how the rolls are being displayed so i will go ahead and close this issue out and see if i can't figure out how to display them differently.

Thanks