rtaormina / epanetCPA

epanetCPA is a MATLAB® toolbox for assessing the impacts of cyber-physical attacks on water distribution systems
23 stars 17 forks source link

Few small issues using the toolbox #6

Open NoyKad opened 5 years ago

NoyKad commented 5 years ago

Hi @rtaormina, I would like to thank you for sharing the epanetCPA toolbox, herein some small issues I encountered in the initial setup:

  1. If an attacked component (in the network) is not listed in 'what_to_store' (under [CYBEROPTIONS] tag), the simulation then stops and issue an error - suggesting to add a catch and try blocks in presimulation checks to alert the user.

  2. If component ID name in the .inp file have an underscore ('_'), the toolbox then split the name (e.g., Tank_1 will become Tank), what can issue errors - suggesting while creating the .inpx file, to replace all names to valid names or to considered replacing the split name function to a more tolerated operation or to alert the user.

  3. If water tank in the .inp file is linked to more then one pipe, the toolbox will create dummy tanks per pipe link in the .inpx file - resulting duplicated tank's ID names and issue and error - suggesting to add instructions to the toolbox guide how to avoid this case.

  4. If a component is used in the cyber-layer and the component's ID name in the .inp file identify only by numbers (e.g., Pump '335'), the toolbox issue an error - suggesting to add instructions to the toolbox guide how to avoid this case.

  5. Attack on actuators (please see my impervious issue on the subject)

That all for now, Thank you again and I hope this information will be useful.