rtbhouse-apps / gtm-tag-template-hosted-js

GTM Tag template for hosted js
Apache License 2.0
2 stars 1 forks source link

Tags fired marked as "Still running" #4

Closed rafa-suagu closed 1 year ago

rafa-suagu commented 1 year ago

Implementing the tracking with this GTM Custom Template we get the "Still running" state on each event that we send except with the Base Tag.

The reason is simple, except the Base Tag, the required callback data.gtmOnSuccess() / data.gtmOnFailure() is not called.

Just adding the callback on the other events, this issue would be done.

FYI: https://www.simoahava.com/analytics/still-running-google-tag-manager-tags/

dgrtbh commented 1 year ago

thanks for reporting @rafa-as, we'll look into this and let you know

rafa-suagu commented 1 year ago

@abahdanovich @dgrtbh thanks for merging the PR! Do you know when can you make a release to GTM Templates to update our template?

dgrtbh commented 1 year ago

@rafa-as we need an additional review before this goes live, we'll keep you posted. Sorry for the wait!

rafa-suagu commented 1 year ago

Thanks for the update @dgrtbh !

dgrtbh commented 1 year ago

@rafa-as I got information that this change was deployed, so I'm closing this for now, but let me know if you have any comments regarding this, and thanks again for reporting 🙂

rafa-suagu commented 1 year ago

Thank you @dgrtbh! We've already update our GTM template and everything works properly! A pleasure!