search

rtbrick / bngblaster

The BNG Blaster is an open-source network tester for access and routing protocols.
https://rtbrick.github.io/bngblaster/
BSD 3-Clause "New" or "Revised" License
202 stars 34 forks source link

Omitting pps value in the streams config breaks transmission behaviour #211

Closed bbluser closed 6 months ago

bbluser commented 1 year ago

I'm observing a behaviour in the bngblaster statistics that I cannot explain, I think it's a bug.

The concise description is that if in the streams definition the pps is not set explicitly then the tx-bytes are always zero in the run report, independently of the streams direction, whether "upstream", "downstream" or "both".

The rx-bytes are, however always set. Note though, that the bngblaster manual specifies a default value of 1 for pps, but that does not seem to have an effect if not set explicitly.

To Reproduce Version: 0.8.21 Compiler: GNU (11.3.0)

1.create a config with a stream - e.q. "direction both" - without setting the pps value there

  1. run bngblaster for a while and stop it
  2. examine the tx-bytes values for the stream in the run report. They equal to 0.
  3. in the config set a pps value to 1 for the stream und rerun bngblaster
  4. examine the tx-bytes values for the stream in the run report. They have reasonable values.

Expected behavior

Not setting the pps explicitly should have the same effect as explicitly setting it to 1 - which is the default, says the documentation.

GIC-de commented 9 months ago

I tried but can't reproduce the bug. Could you share the config and log output if started with -l debug please?

GIC-de commented 9 months ago

Can you try with latest release 0.8.29, as I changed something here which might be related to your issue.

bbluser commented 9 months ago

Hi Christian,

surely I can check it but it will take some time. I'm very busy to finish my user stories before I go to vacation on Thursday.

br Janos

Von: Christian Giese @.> Gesendet: Freitag, 24. November 2023 18:38 An: rtbrick/bngblaster @.> Cc: Janos Heilig @.>; Author @.> Betreff: Re: [rtbrick/bngblaster] Omitting pps value in the streams config breaks transmission behaviour (Issue #211)

SECURITY WARNING: This email is from an external source - be careful of attachments and links. Please report suspicious emails to @.***

Can you try with latest release 0.8.29, as I changed something here which might be related to your issue.

— Reply to this email directly, view it on GitHubhttps://github.com/rtbrick/bngblaster/issues/211#issuecomment-1825951301, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCQXNHGDYIIUSDPA42JQLQDYGDLSVAVCNFSM6AAAAAA4UXBEZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRVHE2TCMZQGE. You are receiving this because you authored the thread.Message ID: @.***>

GIC-de commented 6 months ago

Closed by inactivity. Please open new issue if issue still occurs with latest version 0.8.36 or newer.