search

rtchagas / pingplacepicker

An almost plug and play replacement for Google's Place Picker
Apache License 2.0
142 stars 55 forks source link

Select Location text not visible #82

Closed jaseelmohd closed 3 years ago

jaseelmohd commented 4 years ago

Thanks for the great library!,

Please check the below screenshot, the Select location text is not visible on both dark and light theme Screenshot_20201015-205806

tangent-q commented 3 years ago

@rtchagas facing same issue.

It doesn't seem like a theme or colouring conflict issue. Upon doing the layout inspection, seems like TextView (android:id="@+id/tvLocationSelect") has gone to the top of it's parent and has no width/height.

https://github.com/rtchagas/pingplacepicker/blob/master/library/src/main/res/layout/activity_place_picker.xml#L96

What do you think ?

tangent-q commented 3 years ago

@rtchagas Sorry, was using an older version. Updated to the latest 2.2.0 and issue resolved. But it's strange that Gradle wasn't highlighting me that there is an update available. May be while releasing some attributes needs to be set.

@jazeelmohd are you on the latest version ? may be updating will solve your issue.

jaseelmohd commented 3 years ago

@rtchagas Sorry, was using an older version. Updated to the latest 2.2.0 and issue resolved. But it's strange that Gradle wasn't highlighting me that there is an update available. May be while releasing some attributes needs to be set.

@jazeelmohd are you on the latest version ? may be updating will solve your issue.

Just updated now, and it is visible properly