rtcharity / eahub.org

A global directory for effective altruists to connect
https://eahub.org
MIT License
18 stars 6 forks source link

1256 checkbox privacy policy #1293

Closed sebgrebe closed 3 years ago

sebgrebe commented 3 years ago

image

Closes #1256

viktor-yunenko commented 3 years ago

Overall it looks good, the only thing I recommend to adjust is to utilize bs5 form control for the checkbox, it adds the default styles and UX features 👍

image

sebgrebe commented 3 years ago

Thanks, @victor-yunenko, implemented your comment

sebgrebe commented 3 years ago

Overall it looks good, the only thing I recommend to adjust is to utilize bs5 form control for the checkbox, it adds the default styles and UX features 👍

image

@victor-yunenko, you mentioned verbally that my changes in reaction to your comment weren't quite what you had in mind. Could you put here what you exactly had in mind? I suspect it is about exactly following the pattern in profile_update.html, i.e.,

<div class="col col-bool-with-margin-top">
              {% include 'includes/field.html' with form=form field=form.open_to_job_offers %}
            </div>

The reason I didn't use this pattern is that the field name is not what we want to display next to the checkbox, unlike for example in the case of "Open to job offers"

sebgrebe commented 3 years ago

@victor-yunenko, just updated so that is uses the includes/field.html code, which enables clicking on the tag (and also allows for less boilerplate html code)