search

rtcharity / eahub.org

A global directory for effective altruists to connect
https://eahub.org
MIT License
18 stars 6 forks source link

Special signs got cut out in URLs #584

Open michaltrzesimiech opened 5 years ago

michaltrzesimiech commented 5 years ago

image

We could potentially approach to fix this when unbreaking links. If we want to fix this (i.e. by switching "ü" ti "u" instead of dropping it altogether).

michaltrzesimiech commented 5 years ago

It would probably be for the best at this point to keep both versions if we wanted to approach this at all.

michaltrzesimiech commented 5 years ago

Or maybe we should allow Organisers to customise urls for groups? One useful case is that of "GWWC Sheffield", which changed their name to "Effective Altruism" Sheffield: https://eahub.org/group/gwwc-sheffield

taymonbeal commented 5 years ago

Every user has one canonical slug, plus some number of optional redirects. Currently, we transliterate the user's or group's name at creation time into ASCII, and that's their canonical slug. Redirects are used only for profiles imported from the old Hub (and they're not live yet, they're just there in the database).

Our current transliteration library only really handles Cyrillic characters; all others are dropped. There's another one out there that does better, based on a Perl library by an expert linguist, but the Python port's license is incompatible with our project. We'd need somebody who speaks both Perl and Python to do a clean-room re-porting. Alternatively, we could live with the current behavior, or not use ASCII-only slugs at all (which has some risk of compatibility issues when people pass around URLs, but less than was once the case, I think; see https://stackoverflow.com/questions/2742852/unicode-characters-in-urls).

Any thoughts?

taymonbeal commented 5 years ago

Oh, and the idea of letting users change the slugs is also important but separate from this.

michaltrzesimiech commented 5 years ago

Given the constraints, I currently think we should move this discussion to further releases and live with the current behavior for now (but patch https://github.com/rtcharity/eahub.org/issues/578).