rtconner / laravel-tagging

Tag support for Laravel Eloquent models - Taggable Trait
MIT License
882 stars 168 forks source link

incorrect encoding for non-latin symbols #15

Closed 091500 closed 10 years ago

091500 commented 10 years ago

found a bug,

this commit shows the difference between symbols, take a look: https://github.com/rtconner/laravel-tagging/commit/6b7d8300e0e33086320440b81e5b763a55b42d27

compare two versions of $char_map array:

after moving from src/Conner/Tagging/Tag.php to src/Conner/Tagging/TaggingUtil.php the encoding seems to have broken up

was able to fix the bug by copy-pasting the old array

rtconner commented 10 years ago

Thanks for the issue, I'll get this fixed asap.

091500 commented 10 years ago

great! thanks