search

rtconner / laravel-tagging

Tag support for Laravel Eloquent models - Taggable Trait
MIT License
882 stars 168 forks source link

Added persian character maps #192

Closed AmirMehrabi closed 2 years ago

AmirMehrabi commented 4 years ago

Hello, Thank you for this amazing package.

So when I tried to use this package, I realized my Persian/Farsi strings wouldn't process as they should, and as a result, my slugs were all messed up. So I added Persian character maps to the "slug" method.

Please take a look, see if it's any good.

AmirMehrabi commented 4 years ago

This is the new PR that I opened. Can you check it my man? @rtconner

AmirMehrabi commented 3 years ago

Sorry to bother, just wanted to remind you of this PR my man. @rtconner

kossmoss commented 2 years ago

I'd rather simply reuse Illuminate\Support\Str::slug for that

rtconner commented 2 years ago

I'd rather simply reuse Illuminate\Support\Str::slug for that

You can use the config file to set whatever slug method you wanted. https://github.com/rtconner/laravel-tagging/blob/laravel-8/config/tagging.php#L9

AmirMehrabi commented 2 years ago

What do you think about this merge request? @rtconner Do you think it qualifies for a merge?

rtconner commented 2 years ago

I didn't think it did qualified, it overlaps a lot with per-existing modifiers.