rtconner / laravel-tagging

Tag support for Laravel Eloquent models - Taggable Trait
MIT License
882 stars 168 forks source link

Remove version from composer.json #34

Closed marcusmoore closed 9 years ago

marcusmoore commented 9 years ago

As commented previously.

rtconner commented 9 years ago

Thanks!

rtconner commented 9 years ago

So .. the packagist version number .. it's gotta be a quirk on the part of https://packagist.org Kind of annoys my the version is not updating there. I think it's because I had removed the master branch in favor of the two laravel branches. I've set laravel-5 as the primary branch. But packagist seems to not respond to that as it should.

rtconner commented 9 years ago

I sent packagist an email. Hopefully they respond.

marcusmoore commented 9 years ago

In their update schedule section here they mention that packages without the webhook will be crawled once a day. Maybe that's an issue and once the crawler comes back through it'll pick up on the new primary branch?

rtconner commented 9 years ago

I have webhook setup.

marcusmoore commented 9 years ago

Ah...well then...

If you can, comment back with what Packagist's solution is. I'm interested to see how this ends.

rtconner commented 9 years ago

.. no response. Dunno. I added version 1.0.2 .. and packagist accepted that version and published it just fine. So .. I really don't know the issue. Maybe packagist just hates the version "1.0.1" Haha. :stuck_out_tongue_winking_eye:

marcusmoore commented 9 years ago

Noted: Never bump to version 1.0.1. Go straight to 1.0.2.

Ha thanks for replying. Glad it got fixed...somehow.