search

rtcwmp-com / rtcwPro

RtcwPro - Competition Mod for Return to Castle Wolfenstein
http://rtcwpro.com
GNU General Public License v3.0
26 stars 6 forks source link

SV_CVAR restrictions not being respected #252

Closed acelad88 closed 3 years ago

acelad88 commented 3 years ago

Feature #15 implemented server cvar restrictions, and I can see that the defaultcomp.cfg has command sv_cvar r_picmip "IN 0 3"

However, I am able to connect to a server (/connect hyperion-gaming.net:17600;password pikachu) and set cvars to way beyond these limits, giving a competitive advantage that would be considered cheating.

A normal cfg with r_picmip = 3:

112936-hateful8Adlad-te_frostbite

A cfg with r_picmip = 20:

112915-hateful8Adlad-te_frostbite

natelo commented 3 years ago

Problem is that r_ variables are intercepted by engine so by the time they're cascaded to logic, it's too late as they're already set.

There's two ways that I can think off as how it could be done: 1) By reloading game after logic picks up unsupported values but that's a hacky way and a possible stability issue - essentially two vid_restarts. 2) Sorting on engine level but that would require everyone to use client.

Both options have issues.. If someone sees any other option, feel free ..

krazykaze81 commented 3 years ago

One thing we could do in the meantime is remove the nopicmip flag on the tree textures - that would at least keep trees valid and not allow people to see through them

acelad88 commented 3 years ago

Thanks for the speedy responses guys!

@natelo: Out of the two options, we could survey the community but given that the entire competitive scene is on Discord I don't think it would be a problem for people to use a new client if required. While we're on this topic, maybe it's worth thinking big and looking at building an anti-cheat replacement for punkbuster?

@krazykaze81: That may help indeed, and a temporary patch is better than nothing while a decision is being made on how to achieve the above.

krazykaze81 commented 3 years ago

Using picmip 10 and shader with nopicmip on trees

shot0000

natelo commented 3 years ago

I guess we need to ask community. If they’re willing to accept the client, we can easily address this in a timely manner.

S4NDM4NN commented 3 years ago

The values are set, but could we just kick the client after x time if they do not comply with the restrictions?

natelo commented 3 years ago

Hey S4ND :) It would be an option, but not sure if they would want to go down that path?

Personally I would go with client option as that opens tons of possibilities..but that’s just me.

krazykaze81 commented 3 years ago

The values are set, but could we just kick the client after x time if they do not comply with the restrictions?

That would definitely be an option before we can come out with client

krazykaze81 commented 3 years ago

Testing complete