search

rte-i / Antares_Simulator

Antares-Simulator is an Open Source power system simulator to quantify the adequacy or the economic performance of interconnected energy systems, at short or remote time horizons.
https://antares-simulator.org
Other
1 stars 0 forks source link

RTE Feedback Round 2 #29

Closed hugo-antoine-rtei closed 2 years ago

hugo-antoine-rtei commented 2 years ago

Hello to you both,

RTE have sent some more requests for changes. I will describe them through a code review here.

hugo-antoine-rtei commented 2 years ago

Also: Indeed, it seems to me that the adq-patch is only for studyMode == economy. Please make sure that antares-solver won't run if adq-patch is enabled and the study mode is not economy (adequacy or adequacy-draft). See src/solver/application.cpp, lines 47-141 for how to achieve that. Make sure to define a new exception in src/libs/antares/exception/LoadingError.hpp, derived from Error::LoadingError so that it will be caught appropriately.