CR20 based on feature/adq-patch

[hugo-antoine-rtei]

Hello Pengbo, I found a couple of issues when trying this out:

• The first one is with the greyed boxes for Marginal cost and market bid. When I create a thermal cluster, put it in "Use cost timeseries" mode, it will grey out the correct boxes. Then create another one, it will be in Set manually mode, but with the boxes still greyed out.
• The second one is with the cost itself. It doesn't appear to be put in the Overall cost of the system (OV. cost) or Operational cost of the system (OP. cost) in the result tab. In the following study (check the latest result), the cost of the system is 0 when using the gas cluster with the price defined with the cost timeseries: Thermal Def.zip

[rtei-pw]

Hello Pengbo, I found a couple of issues when trying this out:

• The first one is with the greyed boxes for Marginal cost and market bid. When I create a thermal cluster, put it in "Use cost timeseries" mode, it will grey out the correct boxes. Then create another one, it will be in Set manually mode, but with the boxes still greyed out.
• The second one is with the cost itself. It doesn't appear to be put in the Overall cost of the system (OV. cost) or Operational cost of the system (OP. cost) in the result tab. In the following study (check the latest result), the cost of the system is 0 when using the gas cluster with the price defined with the cost timeseries: Thermal Def.zip

Thanks! Please re-test the bug fix

[hugo-antoine-rtei]

Hello Pengbo, The changes you've made are good ! The grey boxes are indeed gone, and the op & ov costs are now being updated properly. However I now have an issue with the cost calculated. I ran the same example I sent to you earlier, with the new version: Thermal Def.zip. In the latest result you will see that the cost of new cluster is 37100 € / hour. But, with the parameters I set, I should have: cost/MWh = fuel cost 3.6 100 / efficiency + co2 emission factor co2 cost + variable o&m cost cost/MWh = 10 3.6 100 / 100 + 1 1 + 10 = 47€/MWh cost = 4700€ / hour Do you know how I end up with this value ? Hugo

[rtei-pw]

Hello Pengbo, The changes you've made are good ! The grey boxes are indeed gone, and the op & ov costs are now being updated properly. However I now have an issue with the cost calculated. I ran the same example I sent to you earlier, with the new version: Thermal Def.zip. In the latest result you will see that the cost of new cluster is 37100 € / hour. But, with the parameters I set, I should have: cost/MWh = fuel cost 3.6 100 / efficiency + co2 emission factor co2 cost + variable o&m cost cost/MWh = 10 3.6 100 / 100 + 1 1 + 10 = 47€/MWh cost = 4700€ / hour Do you know how I end up with this value ? Hugo

Hello, fixed, missed a point.

[hugo-antoine-rtei]

The price seems good now ! Next thing I noticed is, when I resized the columns of the Fuel Cost:

I end up with weird problems:

• Once I save, I can't change it back, if I re-save it will keep the >1 number of columns
• Once I close the study and load it again, it will delete all the values

Is it possible to use more than 1 year of data for the fuel cost and co2 cost ? (I assume no) Then would it be possible to remove the "resize" option ? Or, if it's easier should we just accept several years of data, provided that the number columns is the same for Time-series, Fuel Cost & CO2 Cost ?

During the last meeting I also got comments regarding naming:

• Would it be possible to change the Time-Series window to "Availability" ?
• Can we put that window (availability) all the way to the right ?

[Milos-RTEi]

Done:

• change the Time-Series window to "Availability" & move it all the way to the right.
• accept multiple TS for Fuel and CO2 Cost without GUI issues.
• log out error before simulation start if TS count for CO2 and Fuel cost are different from 1 or number of TS in "Availability".

TODO:

• implement the logic for the last point in the "Done" list. For now, all the calculations are done with the first TS.
• after the "no grey disable property"(aa2d4f6) the GUI is unstable. Is it the same for you @hugo-antoine-rtei? because you did not mention anything E.g. In "new cluster" tried changing Marginal or Market bid cost. Simulation crashes. In "new cluster 2" tried changing Cost Generation to "Use cost timeseries". Simulation crashes. The solution before the mentioned commit was much more stable but had drawbacks mentioned by Hugo. I'll see if I can figure this one out.

[Milos-RTEi]

Done:

• in addition to "productionCost" create "productionCostTs" to be used if the time series is > 1.

• use "productionCostTs" in "state.cpp" for calculating "thermalClusterOperatingCost" if the time series is > 1. Now we have different results for OP & OV Cost for each MC year - depending witch TS the MC year is using.

• refactor "productionCost" due to Segmentation faults (7a2166d) when property.update is used

• create marketBidCostPerHourTs Matrix

• create marginalCostPerHourTs Matrix Now TS is implemented in all files.

Remaks:

• Thermal Cluster -> Common - same modulations applied to all TS
• Thermal Cluster -> Common - only first TS Net Marginal Cost and Net Market Bid visible in UI->common panel
• Thermal Cluster -> Thermal Cluster List - when "Use cost timeseries" is used total marginal cost is calculated as the average of the first TS
• no more GUI instability mentioned in the previous comment. The issue was due to Segmentation faults in "productionCost".

TODO:

• when Fuel Cost or CO2 Cost TS are modified -> it is not visible/updated in Net Marginal Cost and Net Market Bid in the Common panel. Antares needs to be closed and opened to update the changes. This cause no problem with the simulation results.

[Milos-RTEi]

I am closing this. CR20 has been merged to RTE develop branch. https://github.com/AntaresSimulatorTeam/Antares_Simulator/pull/1272