Fix build: parameter parsing via FDT got broken

rtfb / riscv-hobby-os

Other

27 stars 5 forks source link

Fix build: parameter parsing via FDT got broken #45

Closed rtfb closed 2 years ago

rtfb commented 2 years ago

c2fbe93 has introduced zeroing out of bss section, which trashes a1 register, which contains the address of FDT header on boot. The fix is trivial: replace a0/a1 with t0/t1.

The breakage should've been caught by Github actions, but they don't run automatically for the first-time contributors, and that's how it went unnoticed.

rtfb commented 2 years ago

FYI, @RinHizakura, this is a little fixup on top of your bss section fix.

rtfb commented 2 years ago

Also, currently disabled these tests completely with #44 because they're broken on Github machines for some reason, while they still work on my laptop. Not sure yet why they stopped working.