search

rtfeldman / elm-css

Typed CSS in Elm.
https://package.elm-lang.org/packages/rtfeldman/elm-css/latest
BSD 3-Clause "New" or "Revised" License
1.24k stars 197 forks source link

Media Query documentation should not use `@` symbols in links #397

Open MiracleBlue opened 6 years ago

MiracleBlue commented 6 years ago

Hi there,

The rendered documentation page for Media.elm has a couple of links to MDN's @media documentation pages, and due to the @ symbol appearing in these URLs, the Markdown parser seems to be turning them into mailto links instead of normal web links.

One specific case can be found here: http://package.elm-lang.org/packages/rtfeldman/elm-css/13.1.1/Css-Media#MediaType

The link it references https://developer.mozilla.org/en-US/docs/Web/CSS/@media#Media_types becomes mailto:https://developer.mozilla.org/en-US/docs/Web/CSS/@media#Media_types

Not sure if this should be a bug filed with elm-markdown or not, but I thought I'd start here.

tolgap commented 6 years ago

The URL without @ seems to redirect to the same page. It could simply be removed: https://developer.mozilla.org/en-US/docs/Web/CSS/media#Media_types

rtfeldman commented 6 years ago

Thanks for the report @MiracleBlue, and thanks for identifying a fix @tolgap! I edited the title to reflect what we should do about this.