search

rtfeldman / elm-css

Typed CSS in Elm.
https://package.elm-lang.org/packages/rtfeldman/elm-css/latest
BSD 3-Clause "New" or "Revised" License
1.23k stars 196 forks source link

`Css.important` on `Css.batch` output only applies to last Css.Style #534

Open Chadtech opened 3 years ago

Chadtech commented 3 years ago

Hello!

Today I ran code like this..

    [ Css.borderTopLeftRadius radiusSize
    , Css.borderTopRightRadius radiusSize
    , Css.borderBottomLeftRadius radiusSize
    , Css.borderBottomRightRadius radiusSize
    ]
        |> Css.batch
        |> Css.important

.. and the important was only applied to the last style.

I managed to reproduce it in this ellie: https://ellie-app.com/c8R5mP4Kvxsa1 , where specialBorderRadius should be applying a border radius to the top right and bottom left corners because of the important, but it is only applied to the top right corner.

I can see the code for why this is. There appears to be a mapLastProperty function that Css.important is using.

I would be happy to make the PR for this. Just let me know!