search

rtfeldman / elm-css

Typed CSS in Elm.
https://package.elm-lang.org/packages/rtfeldman/elm-css/latest
BSD 3-Clause "New" or "Revised" License
1.23k stars 196 forks source link

Set display: none and add elm-css-style-wrapper class #559

Closed bcardiff closed 2 years ago

bcardiff commented 2 years ago

Fixes #557

Using display: none; seems like a good default and still fixes #542.

I think it might be worth adding a class like elm-css-style-wrapper in case the display: none is not good or if someone needs to override the style as @ymtszw needed.

If that's the case using the following will allow to override even the inline display: none; [^1]

.elm-css-style-wrapper[style] { 
   /* your style */
}

I based this change on 17.0.1 in case a 17.0.2 is wanted.

[^1]: Override Inline Styles with CSS

rtfeldman commented 2 years ago

Awesome, thanks @bcardiff! 🎉