Html styled keyed experiment - Githubissues

rtfeldman / elm-css

Typed CSS in Elm.

https://package.elm-lang.org/packages/rtfeldman/elm-css/latest

BSD 3-Clause "New" or "Revised" License

1.23k stars 196 forks source link

Html styled keyed experiment #585

Closed micahhahn closed 1 year ago

micahhahn commented 1 year ago

This PR is an experiment on top of https://github.com/rtfeldman/elm-css/pull/584 where we join keyed + lazy together into one function.

I feel pretty happy with the results but there were a couple snags where I had to make tradeoffs:

We need to eat another of the lazy args to pass the key, meaning we can only have lazyNode ... lazyNode6
Elm does not support tuples above 3 elements, so the signatures of lazyNode to lazyNode3 look different from lazyNode4 to lazyNode6. "Once you get to four [tuple elements], it is best to make a record with named entries." 🤷‍♂️

micahhahn commented 1 year ago

Closing as changes have been merged into #584