search

rtfeldman / elm-iso8601-date-strings

Convert between ISO-8601 date strings and Time.Posix
https://package.elm-lang.org/packages/rtfeldman/elm-iso8601-date-strings/latest
BSD 3-Clause "New" or "Revised" License
34 stars 21 forks source link

Error in readme: Time.Posix is not in UTC #26

Open malaire opened 4 years ago

malaire commented 4 years ago

Readme says

If it encounters a UTC offset in the string, it normalizes and discards it such that the resulting Time.Posix value is in UTC no matter what.

The end part "such that the resulting Time.Posix value is in UTC no matter what." is wrong. Time.Posix is never in UTC as it's independent from any timezone.

jamesrweb commented 3 years ago

Internally in the code there is some conversion work to translate the output value to UTC like in the fromTime and toTime functions so that the parsed output will be a UTC equivelant Time.Posix. Maybe the wording could be better here though... any suggestions?

jamesrweb commented 1 year ago

@rtfeldman I think this issue could be closed now, what do you think?