rtfeldman / elm-spa-example

A Single Page Application written in Elm
https://dev.to/rtfeldman/tour-of-an-open-source-elm-spa
MIT License
3.28k stars 530 forks source link

Be explicit on logout sending a null value #87

Open nikoskalogridis opened 4 years ago

nikoskalogridis commented 4 years ago

Instead of sending a Maybe value we send explicitly a Encode.null value in the logout function.

The main reason I am proposing this is that SimulatedEffect.Ports.send takes always a Decode.Value so its easier to test this.

It's also not preferred as said in the official elm docs

Sending Json.Decode.Value through ports is recommended, but not the only way