search

rtfeldman / seamless-immutable

Immutable data structures for JavaScript which are backwards-compatible with normal JS Arrays and Objects.
BSD 3-Clause "New" or "Revised" License
5.37k stars 195 forks source link

Immutable.from #123

Closed ericclemmons closed 8 years ago

ericclemmons commented 8 years ago

It's common convention (especially to thousands using ESLint presets) to require new before capitalized functions (Immutable), as those are typically constructors:

http://eslint.org/docs/rules/new-cap

Would you accept a PR for Immutable.from(...), which is simply an alias to Immutable?

This would allow users to maintain convention and avoid littering their code with // eslint-disable-line everywhere they use this project.

👍 on this project BTW!

rtfeldman commented 8 years ago

Sure, makes sense to me! 😃

ericclemmons commented 8 years ago

Work is being done in #126...

rtfeldman commented 8 years ago

Released in 6.1.0. Thanks again @ericclemmons!