search

rtfeldman / seamless-immutable

Immutable data structures for JavaScript which are backwards-compatible with normal JS Arrays and Objects.
BSD 3-Clause "New" or "Revised" License
5.37k stars 194 forks source link

Update deep merge() to work with an array argument #140

Closed lelandmiller closed 7 years ago

lelandmiller commented 8 years ago

Maybe I am misunderstanding how this should work. I was expecting a deep merge to deeply merge each object in an array sequentially. The behavior I expected is what I added a test for. Please let me know if I am misinterpreting the API, I can fix this in another way if you would like as well.

lelandmiller commented 8 years ago

Looks like the build failed to a credentials issue, not test failures:

Zuul tried to run tests in saucelabs, however no saucelabs credentials were provided.
lelandmiller commented 8 years ago

Just wanted to ping on this and see if anyone had any feedback.

Thanks :-)

crudh commented 8 years ago

@lelandmiller looks like a bug and a legit fix to me! @rtfeldman ?

lelandmiller commented 7 years ago

Hey, @rtfeldman! just wanted to check in on this again to see if there is anything I could do to possibly get this in a published version of seamless-immutable.

Thanks!

rtfeldman commented 7 years ago

@lelandmiller really sorry I took so long getting to this! Looks good to me.

If you can resolve the merge conflicts I'll merge and publish this.

lelandmiller commented 7 years ago

Closing and continuing on #156.