search

rtfeldman / seamless-immutable

Immutable data structures for JavaScript which are backwards-compatible with normal JS Arrays and Objects.
BSD 3-Clause "New" or "Revised" License
5.37k stars 194 forks source link

handles setting a new object on existing leaf array correctly #152

Closed marbemac closed 7 years ago

marbemac commented 7 years ago

closes #151

I'm not terribly familiar with the testing suite, so please let me know if there's a better way to do this. For examples sake, I included a test that demonstrates the issue. This test fails on the latest published seamless-immutable, and is fixed w this commit.

marbemac commented 7 years ago

Also wasn't sure if I should include re-built distributions - let me know!

marbemac commented 7 years ago

Alrighty, updated! I included the dist files as well, but just realized you merged some changes into master earlier today - how would you like to handle it?

rtfeldman commented 7 years ago

@marbemac don't worry about the dist files; I always rebuild them before publishing. 😄

marbemac commented 7 years ago

Sweet! Thanks for reviewing this so quickly.

rtfeldman commented 7 years ago

@marbemac can you reset the dist files to what's on master and push that to resolve the merge conflict?

rtfeldman commented 7 years ago

Thanks @marbemac! Published as 6.1.3.