search

rtfeldman / seamless-immutable

Immutable data structures for JavaScript which are backwards-compatible with normal JS Arrays and Objects.
BSD 3-Clause "New" or "Revised" License
5.36k stars 194 forks source link

Added static Immutable.sortBy(array[, sorter]) function #211

Open LukeusMaximus opened 7 years ago

LukeusMaximus commented 7 years ago

Adds a static sortBy function to the Immutable object. It exposes the basic JS Array#sort functionality. It can take an optional sorting function as per Array#sort.

LukeusMaximus commented 7 years ago

I'm unsure how to address the build issues in Travis. Can someone assist?

foray1010 commented 7 years ago

would prefer if no change after sort, return the same reference

LukeusMaximus commented 7 years ago

What's going on with this Travis build? I'm still unable to proceed.

seanf commented 6 years ago

Build log mentions zuul. Probably related to saucelabs: https://github.com/rtfeldman/seamless-immutable/pull/249#issuecomment-382324649

seanstrom commented 4 years ago

@pekeler would this this pull request be ready to merge if the remaining review comments were resolved?