Add jsdom to fix failing tests

rtfeldman / seamless-immutable

Immutable data structures for JavaScript which are backwards-compatible with normal JS Arrays and Objects.

BSD 3-Clause "New" or "Revised" License

5.37k stars 195 forks source link

Add jsdom to fix failing tests #246

Closed crudh closed 6 years ago

crudh commented 6 years ago

Do not merge this. It has degenerated into a cat and mouse game with Saucelabs :)

@rtfeldman the tests are failing. It seems like it's because of File and Blob not being available in Node.

This PR adds jsdom and initializes it in Immutable.spec.js, the only place where those are used. I also removed a few unused exports in TestUtils (which should be undefined anyway).

crudh commented 6 years ago

Now everything seems to build except for the browser tests, and they have been broken for some time.

crudh commented 6 years ago

I'm closing this. I don't have time to debug the saucelabs/zuul tests. Most of the commits improves the situation at least, so feel free to cherry pick or copy for another PR.

The android version was capped at 6.0 since the default emulator doesn't work on 7 and above, but I didn't find a way to specify the emulator in zuul.yml. And the Safari minimum version was bumped since it seems Saucelabs doesn't support it anymore.