search

rtfeldman / seamless-immutable

Immutable data structures for JavaScript which are backwards-compatible with normal JS Arrays and Objects.
BSD 3-Clause "New" or "Revised" License
5.37k stars 195 forks source link

Fix failing unit tests due to File/Blob #247

Closed crudh closed 6 years ago

crudh commented 6 years ago

The unit tests are failing. It seems like it's because of File and Blob not being available in Node.

This PR adds jsdom and initializes it in Immutable.spec.js, the only place where those are used. I also removed a few unused exports in TestUtils (which should be undefined anyway). It also bumps the node version to a more recent LTS on Travis to fix an issue.

This won't fix the failing zuul/Saucelabs tests though. There are some commits in #246 that improves the situation, but the main problem is tunneling failures that I am unsure on how to fix.

myshov commented 6 years ago

Hi! I've fixed issue with tests here https://github.com/rtfeldman/seamless-immutable/pull/249

crudh commented 6 years ago

@myshov nice! I'll close this.