Fix non truthy custom merger results

rtfeldman / seamless-immutable

Immutable data structures for JavaScript which are backwards-compatible with normal JS Arrays and Objects.

BSD 3-Clause "New" or "Revised" License

5.37k stars 195 forks source link

Fix non truthy custom merger results #248

Closed crudh closed 6 years ago

crudh commented 6 years ago

Merging with a custom merger ignores all non truthy results. It should only ignore undefined. See issue #244.

Since this changes the behavior of custom mergers a major version bump is warranted.

This fixes #244.

nickydonna commented 6 years ago

@crudh any news regarding this??

crudh commented 6 years ago

@donnanicolas sorry, I don't think this is a high priority project for @rtfeldman anymore after his switch to Elm. I don't have any access to commit changes and I no longer use the library. I just jumped in since I contributed the custom mergers, so it seemed like my mess to clean up 😄

crudh commented 6 years ago

@donnanicolas I was given collaborator access so I'll merge this now. It will be in the next release.