search

rtfeldman / seamless-immutable

Immutable data structures for JavaScript which are backwards-compatible with normal JS Arrays and Objects.
BSD 3-Clause "New" or "Revised" License
5.37k stars 195 forks source link

Fix broken build in travis-ci and fix tests #249

Closed myshov closed 6 years ago

myshov commented 6 years ago

I just don't like the red label in the readme file build:failed. :) This pr fix this issue.

myshov commented 6 years ago

Now all checks have been passed. But there is some problem with zuul and saucelab.com. I think that some time ago there was some sort of free plan on saucelabs.com, but now there is no anything like that. There is only free trial for 14 days.

@rtfeldman I have deleted checks for different browsers because they prevented green build on travis-ci. Should we find other alternatives to saucelabs.com or can we merge this pr in the current shape?

seanf commented 6 years ago

There's still supposed to be some sort of free plan on saucelabs.com for open source projects (especially libraries): https://saucelabs.com/open-source/open-sauce https://saucelabs.com/open-source

myshov commented 6 years ago

@seanf I still hope that someone of the maintainers will come here and sort it out.

crudh commented 6 years ago

Thanks @myshov and @seanf, I will send a request to saucelabs and see if we qualify. If the response is negative I'll merge this until an alternative is set up.

myshov commented 6 years ago

fixed

myshov commented 6 years ago

@crudh ping

crudh commented 6 years ago

@myshov great! I just want to sync with the repo owner before I start merging stuff, I just got the collaborator invite last week.

crudh commented 6 years ago

@myshov thanks, I'll merge it now. Lets keep the zuul dependency and scripts for now until we either fix it or remove it later.