Cache NODE_ENV to improve performance

rtfeldman / seamless-immutable

Immutable data structures for JavaScript which are backwards-compatible with normal JS Arrays and Objects.

BSD 3-Clause "New" or "Revised" License

5.37k stars 195 forks source link

Closed sudhakar closed 8 years ago

sudhakar commented 8 years ago

Accessing process.env.NODE_ENV property incurs significant performance overhead. See https://github.com/facebook/react/issues/812

rtfeldman commented 8 years ago

The production build has all references to NODE_ENV stripped out by envify, so this won't be a concern there.

Is there a reason you couldn't address the performance concern by using the prod build?

rtfeldman commented 8 years ago

Closing now that #75 exists; let's continue discussion there.