search

rtfeldman / seamless-immutable

Immutable data structures for JavaScript which are backwards-compatible with normal JS Arrays and Objects.
BSD 3-Clause "New" or "Revised" License
5.37k stars 195 forks source link

Add the license to the top of the minified artifacts #92

Closed InsomniacFury closed 8 years ago

InsomniacFury commented 8 years ago

This ties to #91.

Along the same notion of aiming to consume this library in production, it would be helpful if as part of your artifact generation step, it could also add https://github.com/rtfeldman/seamless-immutable/blob/master/LICENSE to make it easier for consumers to abide by the license.

rtfeldman commented 8 years ago

Thanks for the idea, but I prefer minified files to be as small as possible, including removing comments...and I'm not super worried about license enforcement. :smile:

fenduru commented 8 years ago

@rtfeldman if you're not worried about license enforcement, then you should use a license that does not mandate that * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

The intuitive use of this repository would be to ship with the .production.min.js file, which by default is in violation of your own license

fenduru commented 8 years ago

An alternative approach that jquery uses is to have a small comment linking to the full license:

https://github.com/jquery/jquery/blob/2.2.0/dist/jquery.min.js

rtfeldman commented 8 years ago

Good call! Link to the license seems reasonable; that's only a few extra bytes. Would happily accept a PR for that! :smiley: